Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port more changes to JS rules #320

Merged
merged 48 commits into from
Oct 19, 2023
Merged

Port more changes to JS rules #320

merged 48 commits into from
Oct 19, 2023

Conversation

hendrikvanantwerpen
Copy link
Collaborator

@hendrikvanantwerpen hendrikvanantwerpen commented Oct 9, 2023 •
edited
Loading

No description provided.

@hendrikvanantwerpen hendrikvanantwerpen self-assigned this Oct 9, 2023
@hendrikvanantwerpen hendrikvanantwerpen changed the base branch from main to new_js October 9, 2023 16:58
@hendrikvanantwerpen @BekaValentine
Adds current versions of tests, etc.
1bce687 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Reorgs
5e978ce 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Reorg (cont.)
664772e 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Adds default import test & Fixes bugs
ecba922 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Adds CJS versions of tests
3525306 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Removes some commented out queries
37ef4a2 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Adds first vea test
a595055 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Fixes small bug
8b4bfee 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Adds bug fixes for transitive callers
c4f5b45 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Adds some new tests and fixes
050a6cb 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Add remaining tests and bug fixes
fec4e45 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Adds more tests and testing info
2f582a9 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Fixes definiens syntax types
e0f66aa 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Remove unnecessary patterns
310995d 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Adds empty statement block bug fix
9b13fc1 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Adds tests for module.exports.foo pattern
b9d5119 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen @BekaValentine
Adds fix for ES6 default exports
6c33f75 
Co-authored-by: Rebecca Valentine <[email protected]>
@hendrikvanantwerpen
Add comment explaining import & export specifier rules
83a470c
@hendrikvanantwerpen
Fix definiens warning
03d755d
@hendrikvanantwerpen
Drop explicit tree-sitter version dependency
2e2e221
@hendrikvanantwerpen
Remove unconditional scope pass-throughs for empty elements
d8e6c28 
Elements that could be empty (i.e., not have subnodes) connected
their before and after scopes unconditionally. This could lead to
exponential blow ups when they were not empty: the direct pass
through and the path through the elements were equivalent.

Guarding the pass-through with a conditional that ensures it is
only created when there are indeed no sub nodes prevents this.
@hendrikvanantwerpen hendrikvanantwerpen marked this pull request as ready for review October 16, 2023 16:57
@hendrikvanantwerpen hendrikvanantwerpen requested a review from a team as a code owner October 16, 2023 16:57
@github-actions
Copy link

Performance Summary

Comparing base cfcd41a with head a342c0d on typescript_benchmark benchmark. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before 
--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- base/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
4.581^                     :#                                                 
     |                     :#            :                                    
     |                     :#            :                                    
     |                     :#            :                                    
     |                     :#::::        ::::                                 
     |                     :#: :         :: :                                 
     |                     :#: :      :  :: :                                 
     |                     :#: :      :  :: :                                 
     |                    ::#: :      :@@:: :                                 
     |                  @@::#: :      :@ :: :     :                           
     |                  @ ::#: :     ::@ :: :   :::                :          
     |               @@ @ ::#: : :   ::@ :: :  :: :  ::@: :: :    ::   :::: : 
   0 +----------------------------------------------------------------------->Gi
     0                                                                   67.81
After 
--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- head/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
4.581^                     :#                                                 
     |                     :#           :                                     
     |                     :#           :                                     
     |                     :#           :                                     
     |                     :#:::        ::::                                  
     |                     :# ::        :: :                                  
     |                   : :# ::     :  :: :                                  
     |                   : :# ::     :  :: :                                  
     |                   :::# ::     :@@:: :                       :          
     |                   : :# ::     :@ :: :    ::        :        :          
     |                   : :# ::     :@ :: :   ::         :       ::          
     |               : @@: :# ::     :@ :: :  :::   :::  ::  :    ::  ::@:::: 
   0 +----------------------------------------------------------------------->Gi
     0                                                                   69.55

@BekaValentine BekaValentine merged commit 169c94f into new_js Oct 19, 2023
6 checks passed
@BekaValentine BekaValentine deleted the new_js_more_changes branch October 19, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BekaValentine BekaValentine BekaValentine approved these changes

Assignees

@hendrikvanantwerpen hendrikvanantwerpen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hendrikvanantwerpen @BekaValentine